Merged
Conversation
cretz
force-pushed
the
spring-4-minimal
branch
from
e521db2 to
2ba97aa
Compare
mjameswh
force-pushed
the
spring-4-minimal
branch
from
2ba97aa to
0be9698
Compare
mjameswh
reviewed
Mar 24, 2026
|
|
||
| - name: Start containerized server and dependencies | ||
| env: | ||
| TEMPORAL_CLI_VERSION: 1.6.1-server-1.31.0-151.0 |
Contributor
There was a problem hiding this comment.
[unrelated] Seems like removing this line is causing test flakes in Nexus tests, not sure why.
mjameswh
reviewed
Mar 24, 2026
| version = getVersionName() | ||
|
|
||
| subprojects { | ||
| apply plugin: "com.palantir.git-version" |
Contributor
There was a problem hiding this comment.
Unrelated, but this was causing Gradle error messages in my environment because jgit used internally by com.palantir.git-version doesn't know how to deal with Git worktrees. AFAICS, we're anyway relying on CLI calls to git, rather than use APIs provided by that plugin.
tconley1428
approved these changes
Mar 24, 2026
mjameswh
approved these changes
Mar 25, 2026
...utoconfigure/src/test/java/io/temporal/spring/boot/autoconfigure/AutoConfigOrderingTest.java
Show resolved
Hide resolved
mjameswh
force-pushed
the
spring-4-minimal
branch
from
32550ad to
eafcc96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
MetricsScopeAutoConfigurationandOpenTracingAutoConfigurationto point to the newer Spring 4 class namesChecklist